Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging for enabled/disabled API Groups #32198

Merged
merged 2 commits into from
Sep 10, 2016
Merged

add logging for enabled/disabled API Groups #32198

merged 2 commits into from
Sep 10, 2016

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 7, 2016 •
edited by jessfraz
Loading

Adds logging to the apiserver to indicate which API groups are enabled and disabled as go through. This will make it easier to identify what's gone wrong in cases where the API server is down during diagnoses and the config is inaccessible, like in GKE tests. For example #32185 (comment) .

@wojtek-t This may have made the problem more obvious.

Add logging for enabled/disabled API Groups

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 7, 2016
@deads2k deads2k assigned sttts and unassigned lavalamp Sep 7, 2016
@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2016

@sttts straightforward logging. I figure I'll open this entire pull as a pick into 1.4.1

@deads2k deads2k added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 7, 2016
@sttts
Copy link
Contributor

sttts commented Sep 7, 2016

Simple patch, simple one-time logging. Maybe use V(1).Infof? Then it can be disabled with --v=0. Otherwiese, lgtm.

@dims
Copy link
Member

dims commented Sep 7, 2016

@deads2k - did you want "fixup storage examples" commit in this PR or a separate PR?

@deads2k deads2k force-pushed the storage-01-make-easier-to-inspect branch from f5d4c25 to 0935fd1 Compare September 7, 2016 14:34
@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2016

@deads2k - did you want "fixup storage examples" commit in this PR or a separate PR?

I had no real preference. I can do it separately if you like.

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2016
@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2016

Simple patch, simple one-time logging. Maybe use V(1).Infof? Then it can be disabled with --v=0. Otherwiese, lgtm.

done.

@deads2k deads2k added this to the v1.5 milestone Sep 8, 2016
@deads2k deads2k mentioned this pull request Sep 9, 2016
Closed
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels Sep 9, 2016
@deads2k deads2k removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2016
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2016
@deads2k deads2k force-pushed the storage-01-make-easier-to-inspect branch from a0a36c4 to f04c0dd Compare September 9, 2016 15:26
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 9, 2016
@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2016
@deads2k deads2k force-pushed the storage-01-make-easier-to-inspect branch from 0935fd1 to 0e37530 Compare September 9, 2016 15:31
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 9, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 9, 2016

GCE e2e build/test passed for commit 0e37530.

@k8s-github-robot k8s-github-robot mentioned this pull request Sep 9, 2016
Closed
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2016

GCE e2e build/test passed for commit 0e37530.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 87526da into kubernetes:master Sep 10, 2016
@saad-ali
Copy link
Member

saad-ali commented Oct 7, 2016

@deads2k Let's get this cherry-picked to the 1.4 release branch so the examples in the release branch are correct.

@jessfraz This is non-blocking for v1.4.1--it is ok for this to be merged after that release is cut, but we should ensure that it does get merged to the release branch at some point.

@saad-ali
Copy link
Member

saad-ali commented Oct 7, 2016

hmm, I can't seem to change the milestone. @jessfraz could you set the v1.4-nonblocking milestone

@jessfraz
Copy link
Contributor

jessfraz commented Oct 7, 2016

I think the github api is freaking out

@saad-ali
Copy link
Member

saad-ali commented Oct 7, 2016

Someone must've pushed changes and left for the Friday =P

@saad-ali saad-ali modified the milestones: v1.4, v1.5 Oct 13, 2016
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2016
@jessfraz jessfraz mentioned this pull request Oct 13, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 14, 2016
Merge pull request #34766 from jessfraz/automated-cherry-pick-of-#31854-
644988e 
#32198-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #31854 #32198 origin release 1.4

Cherry pick of #31854 #32198 on release-1.4.

#31854: Update glusterfs provisioner readme with endpoint/service
#32198: fixup storage examples
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#34766 from jessfraz/automated-cherry-pi…
782bc55 
…ck-of-#31854-kubernetes#32198-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#31854 kubernetes#32198 origin release 1.4

Cherry pick of kubernetes#31854 kubernetes#32198 on release-1.4.

kubernetes#31854: Update glusterfs provisioner readme with endpoint/service
kubernetes#32198: fixup storage examples
@deads2k deads2k deleted the storage-01-make-easier-to-inspect branch February 1, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
10 participants
@deads2k @sttts @dims @googlebot @k8s-bot @k8s-github-robot @saad-ali @jessfraz @k8s-cherrypick-bot @lavalamp