Use federated namespace instead of the bootstrap cluster's namespace in Ingress e2e tests. #32105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Ingress e2e tests.
madhusudancs
added
release-note
k8s-github-robot
added
the
size/M
|
GCE e2e build/test passed for commit b789e22. |
| @@ -94,24 +93,24 @@ var _ = framework.KubeDescribe("Federated ingresses [Feature:Federation]", func( | |||
| jig = newFederationTestJig(f.FederationClientset_1_4) | |||
| clusters = map[string]*cluster{} | |||
| primaryClusterName = registerClusters(clusters, UserAgentName, federationName, f) | |||
| ns = f.Namespace.Name | |||
| ns = f.FederationNamespace.Name | |||
There was a problem hiding this comment.
nit: At other places in this test, we use nsName. Should be consistent.
|
LGTM, thanks! |
nikhiljindal
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit b789e22. |
|
Automatic merge from submit-queue |
pwittrock
added
the
cherry-pick-approved
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-of-#31947-kubernetes#32072-kubernetes#32105-kubernetes#32197-kubernetes#32181-upstream-release-1.4 Automated cherry pick of kubernetes#31947 kubernetes#32072 kubernetes#32105 kubernetes#32197 kubernetes#32181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #31825.
cc @kubernetes/sig-cluster-federation @quinton-hoole
This change is