Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry oauth token fetch in gce cloudprovider #32021

Merged
merged 1 commit into from
Sep 3, 2016
Merged

retry oauth token fetch in gce cloudprovider #32021

merged 1 commit into from
Sep 3, 2016

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Sep 3, 2016 •
edited
Loading

Fixes #31560

The oauth client fetches a token on the initial request of that client. Let's warm the cache.

cc @goltermann @lavalamp

This change is Reviewable

@mikedanese mikedanese added the kind/flake Categorizes issue or PR as related to a flaky test. label Sep 3, 2016
@mikedanese mikedanese added this to the v1.4 milestone Sep 3, 2016
@mikedanese
retry oauth token fetch in gce cloudprovider
1a3ff07 
The ouath client fetches a token on it's first request. Let's warm
the cache to avoid pesky flakes.
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Sep 3, 2016
@mikedanese mikedanese added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Sep 3, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 3, 2016

GCE e2e build/test passed for commit 1a3ff07.

@goltermann goltermann added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 3, 2016

GCE e2e build/test passed for commit 1a3ff07.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1f70140 into kubernetes:master Sep 3, 2016
@mikedanese mikedanese deleted the flake branch September 3, 2016 20:37
@mikedanese mikedanese mentioned this pull request Sep 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@mikedanese @k8s-bot @k8s-github-robot @googlebot @goltermann