Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call push-ci-build.sh from the kubernetes/release repo. #32013

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Call push-ci-build.sh from the kubernetes/release repo. #32013

merged 1 commit into from
Sep 7, 2016

Conversation

david-mcmahon
Copy link
Contributor

@david-mcmahon david-mcmahon commented Sep 2, 2016 •
edited by k8s-oncall
Loading

This change is Reviewable

@david-mcmahon david-mcmahon added area/test-infra area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 2, 2016
@david-mcmahon david-mcmahon added this to the v1.4 milestone Sep 2, 2016
@david-mcmahon david-mcmahon added release-note-none Denotes a PR that doesn't merit a release note. and removed cla: yes labels Sep 2, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2016
@ixdy
Copy link
Member

ixdy commented Sep 2, 2016

Maybe also delete build/push-ci-build.sh in this PR?

That way nobody will think making changes to it has any effect.

@ixdy
Copy link
Member

ixdy commented Sep 2, 2016

(I'm assuming you've confirmed this works, right?)

@david-mcmahon
Copy link
Contributor Author

Yes this has been working fine for the test jobs. Of course My intention is not to check this in today or over the weekend. Hold off on the LGTM label, but feel free to give it a lgtm comment.

@spxtr
Copy link
Contributor

spxtr commented Sep 6, 2016

Has this been tested on PR Jenkins? I think it should still work, since you honor KUBE_GCS_RELEASE_BUCKET, but we should be sure to watch closely after merging.

Also, for now the release repo is super small, but is there any reason to not do a shallow clone? I'm worried about GitHub flaking on us or rate-limiting us.

LGTM though.

@david-mcmahon
Copy link
Contributor Author

It has been tested using kubernetes/test-infra#513 which has been working.

Re: cloning. I assumed that with the move to split up the repo we'd soon have a facility to clone all of the repos we needed upfront in some consistent way? I'm a bit loathe to overoptimize this one-off clone.

I'll be monitoring this very closely when it goes in of course.

@ixdy
Copy link
Member

ixdy commented Sep 6, 2016

I still think we should probably delete build/push-ci-build.sh at the same time.

@david-mcmahon
Copy link
Contributor Author

@ixdy I have #24629 doing all of the cleanup. I want to stage this out.

@spxtr
Copy link
Contributor

spxtr commented Sep 6, 2016

Re: cloning. I assumed that with the move to split up the repo we'd soon have a facility to clone all of the repos we needed upfront in some consistent way? I'm a bit loathe to overoptimize this one-off clone.

Sounds reasonable, and yes, we're working on it.

@david-mcmahon david-mcmahon added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 7, 2016
@david-mcmahon
Copy link
Contributor Author

Carrying forward verbal LGTM to label and upping priority so we can get this in today with time to watch.

@david-mcmahon david-mcmahon added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 7, 2016
@ixdy
Copy link
Member

ixdy commented Sep 7, 2016

fyi @rmmh @k8s-oncall

@k8s-bot
Copy link

k8s-bot commented Sep 7, 2016

GCE e2e build/test passed for commit 329b581.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 7, 2016

GCE e2e build/test passed for commit 329b581.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f61a677 into kubernetes:master Sep 7, 2016
This was referenced Oct 24, 2016
Merged
Merged
roberthbailey added a commit that referenced this pull request Oct 25, 2016
@roberthbailey
Merge pull request #35459 from ixdy/automated-cherry-pick-of-#28922-#…
3d5d1aa 
…29892-#30182-#31025-#32013-#32235-#34359-#35233-upstream-release-1.2

Automated cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233
ixdy added a commit that referenced this pull request Oct 25, 2016
@ixdy
Merge pull request #35458 from ixdy/automated-cherry-pick-of-#28922-#…
9e735dd 
…29892-#30182-#31025-#32013-#32235-#34359-#35233-upstream-release-1.3

Automated cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233
@ixdy ixdy mentioned this pull request Oct 27, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 27, 2016
Merge pull request #35671 from ixdy/automated-cherry-pick-of-#32013-#…
ef551d9 
…32235-#34359-#35233-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #32013 #32235 #34359 #35233

Cherry pick of #32013 #32235 #34359 #35233 on release-1.4.

#32013: Call push-ci-build.sh from the kubernetes/release repo.
#32235: Change push-ci-build.sh to push-build.sh and some cleanup.
#34359: Add support for adding a suffix to the GCS upload dir in
#35233: Delete some old, dead release code
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#35671 from ixdy/automated-cherry-pick-o…
fde6e9f 
…f-#32013-kubernetes#32235-kubernetes#34359-kubernetes#35233-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233

Cherry pick of kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233 on release-1.4.

kubernetes#32013: Call push-ci-build.sh from the kubernetes/release repo.
kubernetes#32235: Change push-ci-build.sh to push-build.sh and some cleanup.
kubernetes#34359: Add support for adding a suffix to the GCS upload dir in
kubernetes#35233: Delete some old, dead release code
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@ixdy
Merge pull request kubernetes#35458 from ixdy/automated-cherry-pick-o…
015cbf0 
…f-#28922-kubernetes#29892-kubernetes#30182-kubernetes#31025-kubernetes#32013-kubernetes#32235-kubernetes#34359-kubernetes#35233-upstream-release-1.3

Automated cherry pick of kubernetes#28922 kubernetes#29892 kubernetes#30182 kubernetes#31025 kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@ixdy ixdy

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/test-infra lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@david-mcmahon @ixdy @spxtr @k8s-bot @k8s-github-robot @googlebot