Back porting critical vSphere bug fixes to release 1.3 #31993
Conversation
- Fix unmount for vsanDatastore - Add support for vsan datastore
k8s-github-robot
added
do-not-merge
|
Can a kubernetes member verify that this patch is reasonable Regular contributors should join the org to skip this step. |
|
This cherry-pick looks fine to me, it's entirely in the vsphere provider and thus pretty low risk. However, it's also pretty much the time that 1.4 is going to be cut, so it's not 100% clear to me we're going to cut another 1.3.x release. I'm happy to cherry-pick it into the branch in case we do. Summoning @smarterclayton and @thockin for their opinions. |
|
@k8s-bot ok to test |
|
@brendandburns ./hack/../hack/verify-boilerplate.sh script has failed, it doesn't seem related to this pr: |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@kubernetes/rh-storage |
|
@brendandburns anything else required for this pr? |
|
This is ok on my side, given that everyone seems ok w/ it. Cherry-pick approved. |
brendandburns
added
cherry-pick-approved
|
@dagnello The key error is: Can you check and see what the diff is? My guess is that boilerplate changed between 1.3 and head and you're going to need to manually correct it for what 1.3 expects. (sorry about that) --brendan |
dagnello
force-pushed
the
release-1.3_vSphereBugFixes
branch
from
5ef05be to
465eb83
Compare
|
@brendandburns thank you, pr has been updated |
|
GCE e2e build/test passed for commit 465eb83. |
brendandburns
added
lgtm
|
LGTM. Thanks |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 465eb83. |
|
Automatic merge from submit-queue |
…BugFixes Automatic merge from submit-queue Back porting critical vSphere bug fixes to release 1.3 vSphere cloud provider plugin was first introduced in Kubernetes 1.3.0. The two PRs listed below contain critical volume attach/detach related fixes. Without these fixes, vSphere in 1.3 lacks the ability to consistently attach/detach volumes correctly especially in a busy cluster. These changes only affect the vSphere cloud provider. - kubernetes#29172 - kubernetes#30535
vSphere cloud provider plugin was first introduced in Kubernetes 1.3.0. The two PRs listed below contain critical volume attach/detach related fixes. Without these fixes, vSphere in 1.3 lacks the ability to consistently attach/detach volumes correctly especially in a busy cluster.
These changes only affect the vSphere cloud provider.
This change is