Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heapster liveness probe #31878

Merged
merged 2 commits into from
Sep 1, 2016
Merged

Add Heapster liveness probe #31878

merged 2 commits into from
Sep 1, 2016

Conversation

mksalawa
Copy link
Contributor

@mksalawa mksalawa commented Sep 1, 2016 •
edited
Loading

What this PR does / why we need it:
Add liveness probe for heapster service.

Which issue this PR fixes
kubernetes-retired/heapster#1251

Release note:

Added liveness probe to Heapster service.

This change is Reviewable

@mksalawa
Copy link
Contributor Author

mksalawa commented Sep 1, 2016

cc @piosz

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Sep 1, 2016
@piosz piosz assigned piosz and unassigned zmerlynn Sep 1, 2016
@piosz piosz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Sep 1, 2016
@piosz piosz added this to the v1.4 milestone Sep 1, 2016
@piosz
Copy link
Member

piosz commented Sep 1, 2016

add to whitelist

@piosz
Copy link
Member

piosz commented Sep 1, 2016

LGTM

@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2016
@piosz
Copy link
Member

piosz commented Sep 1, 2016

This is required for #29023 so should be include into 1.4.

@piosz
Copy link
Member

piosz commented Sep 1, 2016

ok to test

@piosz
Copy link
Member

piosz commented Sep 1, 2016

cc @mwielgus

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

GCE e2e build/test passed for commit 92c7fea.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit df24500 into kubernetes:master Sep 1, 2016
@k8s-github-robot k8s-github-robot mentioned this pull request Sep 1, 2016
Closed
@piosz piosz mentioned this pull request Sep 2, 2016
Closed
@mksalawa mksalawa deleted the heapster_liveness_probe branch September 12, 2016 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@mksalawa @k8s-bot @piosz @k8s-github-robot @zmerlynn @googlebot