Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS reporting "The parameter KmsKeyId requires the parameter Encrypted to be set." #31334

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Fix AWS reporting "The parameter KmsKeyId requires the parameter Encrypted to be set." #31334

merged 1 commit into from
Aug 24, 2016

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Aug 24, 2016 •
edited by k8s-oncall
Loading

  • use aws.String/Int/Bool functions
  • don't set the key to empty string, use nil instead

@justinsb @kubernetes/sig-storage

This change is Reviewable

@jsafrane
Fix AWS reporting "The parameter KmsKeyId requires the parameter Encr…
8cd5e26 
…ypted to be set."

- use aws.String/Int/Bool functions
- don't set the key to empty string, use nil instead
@jsafrane jsafrane added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. team/cluster release-note-none Denotes a PR that doesn't merit a release note. labels Aug 24, 2016
@jsafrane jsafrane added this to the v1.4 milestone Aug 24, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 24, 2016

GCE e2e build/test passed for commit 8cd5e26.

@justinsb
Copy link
Member

LGTM - thanks for fixing @jsafrane

@justinsb justinsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 24, 2016

GCE e2e build/test passed for commit 8cd5e26.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f96b8fc into kubernetes:master Aug 24, 2016
@k8s-github-robot k8s-github-robot mentioned this pull request Aug 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @k8s-bot @justinsb @k8s-github-robot @googlebot