Explicitly set CLOUDSDK_CONFIG override early in e2e-runner #31330
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixdy
added
area/test-infra
release-note-none
ixdy
changed the title
k8s-github-robot
added
the
size/XS
|
GCE e2e build/test passed for commit 12ea9cb. |
|
lgtm |
vishh
added
the
lgtm
|
Automatic merge from submit-queue |
| @@ -48,6 +48,10 @@ STAGE_KUBEMARK="KUBEMARK" | |||
| : ${KUBE_GCS_RELEASE_BUCKET:="kubernetes-release"} | |||
| : ${KUBE_GCS_DEV_RELEASE_BUCKET:="kubernetes-release-dev"} | |||
|
|
|||
| # Explicitly set config path so staging gcloud (if installed_ uses the same path | |||
There was a problem hiding this comment.
maybe fix the typo though @fejta (s/_/)/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing this is why a number of gci-on-gke builds started failing after kubernetes/test-infra#432 was merged - we're overriding the gcloud configuration location from the default, so the activated service account no longer works. Previously we did this service activation late, but after we'd overridden the value.
I've changed it to explicitly set to a known-good value every time at the very start.
cc @vishh @maisem @spxtr @fejta
This change is