Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Namespace admission plug-ins #31250

Merged
merged 1 commit into from
Aug 27, 2016
Merged

Remove deprecated Namespace admission plug-ins #31250

merged 1 commit into from
Aug 27, 2016
+2 −501

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Aug 23, 2016 •
edited
Loading 

The NamespaceExists and NamespaceAutoProvision admission controllers have been removed.

All cluster operators should use NamespaceLifecycle.

Fixes #31195

This change is Reviewable

@derekwaynecarr derekwaynecarr added this to the v1.4 milestone Aug 23, 2016
@derekwaynecarr
Copy link
Member Author

/cc @kubernetes/rh-cluster-infra

@k8s-github-robot k8s-github-robot added kind/old-docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 23, 2016
@derekwaynecarr
Copy link
Member Author

Documentation update: kubernetes/website#1079

@derekwaynecarr derekwaynecarr added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Aug 23, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 23, 2016
@derekwaynecarr
Copy link
Member Author

@eparis - i have no idea what merge bot is complaining about for the doc edit. know what i am missing?

@derekwaynecarr derekwaynecarr mentioned this pull request Aug 23, 2016
Closed
@derekwaynecarr
Copy link
Member Author

/cc @nikhiljindal

eparis
eparis reviewed Aug 23, 2016
View reviewed changes
docs/getting-started-guides/coreos/cloud-configs/master.yaml
@@ -91,7 +91,7 @@ coreos:
ExecStart=/opt/bin/kube-apiserver \
--service-account-key-file=/opt/bin/kube-serviceaccount.key \
--service-account-lookup=false \
--admission-control=NamespaceLifecycle,NamespaceAutoProvision,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota \
--admission-control=NamespaceLifecycle,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind doing this in a seperate commit since it will need a merge by hand? the bot won't touch it...

@derekwaynecarr derekwaynecarr removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. kind/old-docs labels Aug 23, 2016
@derekwaynecarr
Copy link
Member Author

@eparis - updated.

@eparis
Copy link
Contributor

eparis commented Aug 23, 2016

/lgtm

@nikhiljindal
Copy link
Contributor

Thanks @derekwaynecarr
Code changes LG.

Should the release note label be release-note-action-required? I assume that apiserver will fail to come up if someone is setting --admission-control=NamespaceExists. So admins will have to make sure that they update their --admission-control flag value if they are using one of these deleted admission controls

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2016
@derekwaynecarr derekwaynecarr added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 26, 2016
@derekwaynecarr
Copy link
Member Author

derekwaynecarr commented Aug 26, 2016 •
edited
Loading

rebased, and updated release note tag.

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 26, 2016

GCE e2e build/test passed for commit c727fdc.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 27, 2016

GCE e2e build/test passed for commit c727fdc.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 90e5559 into kubernetes:master Aug 27, 2016
@lavalamp
Copy link
Member

This merged and then GKE tests went solid red. It's a weekend so I'm going to roll back without investigating.

@lavalamp lavalamp mentioned this pull request Aug 28, 2016
Merged
@lavalamp
Copy link
Member

How did this merge when it broke the GKE test? Is that not a required context?

@eparis
Copy link
Contributor

eparis commented Aug 29, 2016

Smoke GKE is neither in the bot list of required tests https://github.com/kubernetes/contrib/blob/master/mungegithub/submit-queue/deployment/kubernetes/configmap.yaml nor in the github required tests.

How did it break something? Also who owns smoke? Should we turn on in both places?

@derekwaynecarr
Copy link
Member Author

@lavalamp - details on what it broke in GKE would be appreciated. No test
should be using these plug-ins, and I had grepped the repository trying to
find any references. Can someone on Google side find a reference to these
plug-ins and remove them?

On Mon, Aug 29, 2016 at 8:23 AM, Eric Paris notifications@github.com
wrote:

Smoke GKE is neither in the bot list of required tests
https://github.com/kubernetes/contrib/blob/master/
mungegithub/submit-queue/deployment/kubernetes/configmap.yaml nor in the
github required tests.

How did it break something? Also who owns smoke? Should we turn on in both
places?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#31250 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF8dbKLAawtQRR3SmH8NABgiRVPI-OY1ks5qks9dgaJpZM4JrBHi
.

@derekwaynecarr derekwaynecarr mentioned this pull request Aug 29, 2016
Closed
@derekwaynecarr
Copy link
Member Author

Opened #31611 for someone at Google to either show where the GKE references are or for someone at Google to remove the references from GKE.

@lavalamp
Copy link
Member

I just rolled back. I have no idea. Assigned to someone else.

On Mon, Aug 29, 2016 at 7:15 AM, Derek Carr notifications@github.com
wrote:

Opened #31611 #31611 for
someone at Google to either show where the GKE references are or for
someone at Google to remove the references from GKE.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#31250 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAngloIjoqG2pHjQkc33qycFQ0HakyjGks5qkumBgaJpZM4JrBHi
.

@derekwaynecarr derekwaynecarr mentioned this pull request Sep 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eparis eparis

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@derekwaynecarr @eparis @nikhiljindal @k8s-bot @k8s-github-robot @lavalamp @googlebot