Add constants and documentation around AWS magic numbers #31115
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove check for IOPS per GB, AWS checks it on its own.
jsafrane
added
sig/storage
k8s-github-robot
added
the
size/S
|
Yay variables and reuse. |
thockin
added
the
lgtm
| const ( | ||
| MaxIOPSPerGB = 50 | ||
| MinTotalIOPS = 100 | ||
| MaxTotalIOPS = 20000 |
There was a problem hiding this comment.
I checked the EBS link, but I see the numbers are different for SSD and HDD drivers. Are we only considering SSD?
There was a problem hiding this comment.
IOPS can be set by user only for io1 volumes, IOPS for the rest of volumes is preset by AWS.
jsafrane
changed the title
| if volumeOptions.IOPSPerGB <= 0 || volumeOptions.IOPSPerGB > 30 { | ||
| return "", fmt.Errorf("invalid iopsPerGB value %d, must be 0 < IOPSPerGB <= 30", volumeOptions.IOPSPerGB) | ||
| if volumeOptions.IOPSPerGB <= 0 || volumeOptions.IOPSPerGB > MaxIOPSPerGB { | ||
| return "", fmt.Errorf("invalid iopsPerGB value %d, must be 0 < IOPSPerGB <= %d", volumeOptions.IOPSPerGB, MaxIOPSPerGB) |
jsafrane
force-pushed
the
add-constants
branch
from
fd1075c to
a596668
Compare
|
removed checking of iopsPerGB, aws will do it on our behalf. Left capping at 20 000 IOPS. |
|
@jingxu97, PTAL. |
|
GCE e2e build/test passed for commit a596668. |
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit a596668. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, bumped max IOPS/GB to 50, it changed from 30 since last time I checked.
Source: http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSVolumeTypes.html
@kubernetes/sig-storage
This change is