Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound variable issue (set -e). #31025

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Fix unbound variable issue (set -e). #31025

merged 1 commit into from
Aug 19, 2016

Conversation

david-mcmahon
Copy link
Contributor

@david-mcmahon david-mcmahon commented Aug 19, 2016 •
edited by k8s-oncall
Loading

This change is Reviewable

@david-mcmahon david-mcmahon added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/test-infra area/release-eng Issues or PRs related to the Release Engineering subproject release-note-none Denotes a PR that doesn't merit a release note. labels Aug 19, 2016
@david-mcmahon david-mcmahon added this to the v1.4 milestone Aug 19, 2016
@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2016
@ixdy
Copy link
Member

ixdy commented Aug 19, 2016

LGTM

@spxtr
Copy link
Contributor

spxtr commented Aug 19, 2016

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 19, 2016

GCE e2e build/test passed for commit 3c4f749.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2a6237c into kubernetes:master Aug 19, 2016
This was referenced Oct 24, 2016
Merged
Merged
roberthbailey added a commit that referenced this pull request Oct 25, 2016
@roberthbailey
Merge pull request #35459 from ixdy/automated-cherry-pick-of-#28922-#…
3d5d1aa 
…29892-#30182-#31025-#32013-#32235-#34359-#35233-upstream-release-1.2

Automated cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233
ixdy added a commit that referenced this pull request Oct 25, 2016
@ixdy
Merge pull request #35458 from ixdy/automated-cherry-pick-of-#28922-#…
9e735dd 
…29892-#30182-#31025-#32013-#32235-#34359-#35233-upstream-release-1.3

Automated cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@ixdy
Merge pull request kubernetes#35458 from ixdy/automated-cherry-pick-o…
015cbf0 
…f-#28922-kubernetes#29892-kubernetes#30182-kubernetes#31025-kubernetes#32013-kubernetes#32235-kubernetes#34359-kubernetes#35233-upstream-release-1.3

Automated cherry pick of kubernetes#28922 kubernetes#29892 kubernetes#30182 kubernetes#31025 kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@ixdy ixdy

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/test-infra lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@david-mcmahon @ixdy @spxtr @k8s-bot @k8s-github-robot @googlebot