Clear node status before the validation check. #3096
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but can you add a test of some sort? |
brendandburns
force-pushed
the
update
branch
from
76d099f to
9884142
Compare
|
Done (extended existing test) |
lavalamp
added a commit
that referenced
this pull request
Dec 23, 2014
Clear node status before the validation check.
|
I think we'll want to lock down who can set status and who can set spec, but this is ok for now. |
|
well, as it stands for now, no one can set status... (there is a test that Although @ddysher wants to remove that :P --brendan On Mon, Dec 22, 2014 at 4:39 PM, Daniel Smith notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2548