Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #30008 #30479 #30942

Merged
merged 2 commits into from
Sep 9, 2016
Merged

Automated cherry pick of #30008 #30479 #30942

merged 2 commits into from
Sep 9, 2016

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Aug 18, 2016 •
edited by k8s-oncall
Loading

Cherry pick of #30008 #30479 on release-1.2.

This change is Reviewable

@ixdy
Copy link
Member Author

ixdy commented Aug 18, 2016

#30008 is reactive (kubernetes-build-1.2 is currently broken). #30479 is preemptive.

cc @fejta

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Aug 18, 2016
@k8s-github-robot k8s-github-robot mentioned this pull request Aug 19, 2016
Closed
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@fabioy fabioy added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 19, 2016
@fejta fejta added this to the v1.2 milestone Aug 19, 2016
@fabioy fabioy removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 19, 2016
@fejta fejta added cherrypick-candidate do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 19, 2016
@fabioy fabioy added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 19, 2016
@fejta
Copy link
Contributor

fejta commented Aug 19, 2016

Are we concerned with the failing tests?

@fejta
Copy link
Contributor

fejta commented Aug 19, 2016

Otherwise LGTM (although I'm not assigned)

@ixdy
Copy link
Member Author

ixdy commented Aug 19, 2016

@fejta the GKE PR build uses build/util.sh, which doesn't exist in release-1.2. No idea about node e2e, but 1.2 is probably old enough that it wasn't particularly stable yet?

@ixdy
Copy link
Member Author

ixdy commented Aug 19, 2016

@k8s-bot node e2e test this please, issue #IGNORE

@ixdy
Copy link
Member Author

ixdy commented Aug 19, 2016

I think node e2e is just broken on release-1.2...

@ixdy
Copy link
Member Author

ixdy commented Aug 23, 2016

@k8s-bot test this please, issue #IGNORE

@ixdy
Copy link
Member Author

ixdy commented Aug 26, 2016 •
edited
Loading

@k8s-bot test this please, issue #IGNORE

@k8s-bot
Copy link

k8s-bot commented Aug 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@ixdy ixdy mentioned this pull request Sep 9, 2016
Closed
@ixdy
Copy link
Member Author

ixdy commented Sep 9, 2016

@k8s-bot test this please, issue #IGNORE

@rmmh
Copy link
Contributor

rmmh commented Sep 9, 2016

@k8s-bot gke test this please, issue #27462

@k8s-bot
Copy link

k8s-bot commented Sep 9, 2016

GCE e2e build/test failed for commit a5372f2.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@roberthbailey roberthbailey assigned roberthbailey and unassigned fabioy Sep 9, 2016
@roberthbailey
Copy link
Contributor

lgtm

@roberthbailey roberthbailey merged commit d15c663 into kubernetes:release-1.2 Sep 9, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@roberthbailey
Merge pull request kubernetes#30942 from ixdy/automated-cherry-pick-o…
e715fce 
…f-#30008-kubernetes#30479-upstream-release-1.2

Automated cherry pick of kubernetes#30008 kubernetes#30479
@ixdy ixdy deleted the automated-cherry-pick-of-#30008-#30479-upstream-release-1.2 branch May 15, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
9 participants
@ixdy @k8s-cherrypick-bot @fejta @k8s-bot @rmmh @roberthbailey @googlebot @fabioy @k8s-github-robot