Increase concurrent GC workers, adjust the polling interval and timeout in e2e test #30925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesarxuchao
added
the
sig/api-machinery
k8s-github-robot
added
size/S
| timeout = 10 * time.Minute | ||
| default: | ||
| interval = 10 * time.Second | ||
| timeout = 20 * time.Minute |
There was a problem hiding this comment.
What is the actual time it usually takes?
There was a problem hiding this comment.
For 15000 pods, GC is taking 7 mins, with 5 workers. For gce-scale, there are 60000 pods, assuming the time is proportional, it will be 28 mins, but increasing the workers should help decrease the time.
There was a problem hiding this comment.
I guess we can change the timeout to 30 mins just to guarantee that we can see the actual time?
caesarxuchao
force-pushed
the
gc-concurrency
branch
from
e839347 to
a0c6a66
Compare
lavalamp
added
lgtm
|
GCE e2e build/test passed for commit a0c6a66. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #30759 (comment)
This change is