Nodecontroller doesn't flip readiness on pods if kubeletVersion < 1.2.0 #30828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/L
lavalamp
added
lgtm
|
ought to be cherry-picked into 1.2, are we even still making builds of that? |
bprashanth
changed the title
|
I tested this with a master running a custom build and 1.1 nodes, pods didn't get marked NotReady on netsplit for > 40s < 5m. Same custom build, same test, nodes running HEAD code, pods marked NotReady then Ready. |
|
GCE e2e build/test passed for commit 15c9826. |
bprashanth
added
cherrypick-candidate
priority/important-soon
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 15c9826. |
|
Automatic merge from submit-queue |
fabioy
added
cherry-pick-approved
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…pick-of-#28770-kubernetes#30828-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#28770 kubernetes#30828 Cherry pick of kubernetes#28770 kubernetes#30828 on release-1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of the kubelet didn't know how to reconcile pod.Status, so the nodecontroller would mark pods NotReady on netsplit, and if the partition recovered in < 5m, the pods would never get marked Ready resulting in NotReady endpoints indefinitely (till kubelet restart/pod recreate etc).
This change is