Fix binary detection on GKE #3082
Conversation
* kubectl is kubectl.sh in the e2es, so not needed in the path * Use the environment variable, and try to make sure the preview component is installed.
lavalamp
added
the
lgtm
|
@lavalamp does status/lgtm mean that you reviewed it and it looks good and that it should be merged by oncall during working hours? |
|
@erictune I believe that is the intent (although this is a new thing...) |
Fix binary detection on GKE
|
LGTM. I keep missing things assigned to me by 5 or 10 minutes that are then merged. Are assignees like reviewers? |
|
Yeah. But if someone else gets to it before you, don't worry about it. I On Mon, Dec 22, 2014 at 10:12 AM, Maxwell Forbes notifications@github.com
|
|
@erictune @brendandburns Yeah that's the intent of the status/lgtm thing--started by @bgrant0607 who thought it was useful to be able to see in list view which PRs were in "waiting for merge" state. |
component is installed.