more explictly about NoDiskConflicts policy and applicable volume types #30817
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
| @@ -40,7 +40,7 @@ For each unscheduled Pod, the Kubernetes scheduler tries to find a node across t | |||
|
|
|||
| The purpose of filtering the nodes is to filter out the nodes that do not meet certain requirements of the Pod. For example, if the free resource on a node (measured by the capacity minus the sum of the resource requests of all the Pods that already run on the node) is less than the Pod's required resource, the node should not be considered in the ranking phase so it is filtered out. Currently, there are several "predicates" implementing different filtering policies, including: | |||
|
|
|||
| - `NoDiskConflict`: Evaluate if a pod can fit due to the volumes it requests, and those that are already mounted. | |||
| - `NoDiskConflict`: Evaluate if a pod can fit due to the volumes it requests, and those that are already mounted. Currently supported volumes are: AWS EBS, GCE PD, and Ceph RBD. Note, Persistent Volumes are not evaluated, and thus pods that use Persistent Volume Claims are not constrained by this policy. | |||
There was a problem hiding this comment.
I thought this was the other way around - that PVCs were checked? Otherwise the feature wouldn't be very useful to OpenShift
There was a problem hiding this comment.
Only the basic volumes (ebs/gce/rbd) are checked. No PV are checked. The PR is to make the limitation aware.
There was a problem hiding this comment.
Then shouldn't this be:
Only Persistent Volume Claims for those supported types are checked. Persistent Volumes added directly to pods are not evaluated and are not constrained by this policy.
Signed-off-by: Huamin Chen <hchen@redhat.com>
rootfs
force-pushed
the
nodiskconflict-doc
branch
from
588915c to
33affa8
Compare
smarterclayton
added
lgtm
|
GCE e2e build/test passed for commit 33affa8. |
|
Automatic merge from submit-queue |
ericchiang
pushed a commit
to ericchiang/kubernetes
that referenced
this pull request
Aug 18, 2016
Automatic merge from submit-queue more explictly about NoDiskConflicts policy and applicable volume types partially clarify kubernetes#29670 @kubernetes/sig-scheduling
xingzhou
pushed a commit
to xingzhou/kubernetes
that referenced
this pull request
Dec 15, 2016
Automatic merge from submit-queue more explictly about NoDiskConflicts policy and applicable volume types partially clarify kubernetes#29670 @kubernetes/sig-scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially clarify #29670
@kubernetes/sig-scheduling
This change is