Unset a couple GINKGO_TEST_ARGS in kubekins-e2e #30797
Merged
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
|
@k8s-bot node e2e test this issue #IGNORE |
|
@k8s-bot unit test this issue #IGNORE |
|
@k8s-bot verify this issue #IGNORE |
fejta
added
retest-not-required
release-note-none
| @@ -62,5 +63,4 @@ docker run --rm=true -i \ | |||
| -e "WORKSPACE=/workspace" \ | |||
| ${KUBEKINS_SERVICE_ACCOUNT_FILE:+-e "KUBEKINS_SERVICE_ACCOUNT_FILE=/service-account.json"} \ | |||
| "${docker_extra_args[@]:+${docker_extra_args[@]}}" \ | |||
| gcr.io/google_containers/kubekins-test:go1.6.3-docker1.9.1-rev3 \ | |||
| bash -c "bash <(curl -fsS --retry 3 --keepalive-time 2 'https://raw.githubusercontent.com/kubernetes/kubernetes/master/hack/jenkins/e2e-runner.sh')" | |||
| gcr.io/google_containers/kubekins-e2e:v20160817 | |||
There was a problem hiding this comment.
I assume this has already been pushed?
|
LGTM |
ixdy
added
the
lgtm
|
are you planning to replace this hack/jenkins/dockerized-e2e-runner.sh with a |
|
Yup that's the plan! Although depend on the state of things kubernetes/test-infra#385 might have already done this |
|
GCE e2e build/test passed for commit 3b5b70a. |
|
we should probably also move the dockerfile etc to test-infra? |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #30749
This change is