Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nil pointer dereference in pkg/client/transport/round_trippers.go:92 on oauth failure #30790

Closed
ghost opened this issue Aug 17, 2016 · 6 comments
Closed

nil pointer dereference in pkg/client/transport/round_trippers.go:92 on oauth failure #30790

ghost opened this issue Aug 17, 2016 · 6 comments
Assignees
@madhusudancs
Labels
area/apiserver priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
next-candidate

Comments

@ghost
Copy link

ghost commented Aug 17, 2016

On Wed, Aug 17, 2016 at 6:27 AM, Nacho Coloma icoloma@google.com wrote:

Right now I am working with the tutorial from Kelsey, which deploys fine, but after creating the Federation Control Plane (controller-manager and apiserver deployed) I cannot create the clusters in the Federation Server. The Controller Manager shows an error in the logs.

kubectl --namespace=federation create secret generic icoloma-eu --from-file=kubeconfigs/icoloma-eu/kubeconfig
kubectl --context=federation-cluster create -f clusters/icoloma-eu.yaml

The cluster is created but never shows ready. The controller logs shows a NPE:

Recovered from panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:58
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:51
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:41
/usr/local/go/src/runtime/asm_amd64.s:472
/usr/local/go/src/runtime/panic.go:443
/usr/local/go/src/runtime/panic.go:62
/usr/local/go/src/runtime/sigpanic_unix.go:24
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/unversioned/clientcmd/config.go:342
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/plugin/pkg/client/auth/gcp/gcp.go:101
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/golang.org/x/oauth2/transport.go:40
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/transport/round_trippers.go:92

I was reviewing config.go, but could not find what the error message is about. I have tried with different versions of the Federation API server (from v1.3.4 to v1.3.6-beta.0), and tried recreating the cluster several times now, in case I did something wrong.

I have been battling with this for two days. Any help would be super welcome.
@ghost ghost added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/cluster-federation labels Aug 17, 2016
@ghost ghost added this to the v1.4 milestone Aug 17, 2016
@ghost ghost assigned madhusudancs Aug 17, 2016
@ghost
Copy link
Author

ghost commented Aug 17, 2016

@madhusudancs Could you take a look as soon as your v1.4 launch blockers are out of the way?

@k8s-github-robot k8s-github-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 17, 2016
@ianlewis
Copy link
Contributor

FWIW, I get this error when adding a GKE cluster as well, whether the host cluster is AWS or GKE.

@ghost ghost added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 18, 2016
@madhusudancs madhusudancs mentioned this issue Aug 18, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 21, 2016
Merge pull request #30940 from madhusudancs/fed-issue-30790
db777bb 
Automatic merge from submit-queue

Return the current kubeconfig as the starting config in ClientConfigGetter.

This fixes issue #30790.

cc @kubernetes/sig-cluster-federation
@dims
Copy link
Member

dims commented Aug 27, 2016

@madhusudancs we can close this issue now right?

@madhusudancs
Copy link
Contributor

@dims Please don't close this yet. We still need to cherry pick the fix into 1.3 [PR #31483] and I am using this as a tracking issue.

@ghost ghost modified the milestones: next-candidate, v1.4 Aug 29, 2016
@ghost
Copy link
Author

ghost commented Aug 29, 2016

@madhusudancs I've changed the milestone accordingly.

@madhusudancs
Copy link
Contributor

This is now fixed in v1.3, v1.4 and HEAD, so I am closing this issue. Please reopen if you run into this problem again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhusudancs madhusudancs

Labels
area/apiserver priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
next-candidate
Development

No branches or pull requests
4 participants
@madhusudancs @dims @ianlewis @k8s-github-robot