Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bc in the kubekins-test image #30556

Merged
merged 1 commit into from
Aug 13, 2016

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Aug 12, 2016

I finally figured out those

/dev/fd/63: line 124: bc: command not found
/dev/fd/63: line 125: bc: command not found

lines that keep appearing in build logs.

Image is not yet pushed.


This change is Reviewable

It is needed by the shell2junit script.
@ixdy ixdy added area/test-infra release-note-none Denotes a PR that doesn't merit a release note. labels Aug 12, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2016
@spxtr
Copy link
Contributor

spxtr commented Aug 12, 2016

Oh, I was wondering what those lines meant. Looks good, feel free to push the image.

@ixdy
Copy link
Member Author

ixdy commented Aug 13, 2016

pushed.

@k8s-bot unit test this please, issue #IGNORE
@k8s-bot verify test this please, issue #IGNORE

@ixdy
Copy link
Member Author

ixdy commented Aug 13, 2016

@k8s-bot test this please, issue #IGNORE

@k8s-bot
Copy link

k8s-bot commented Aug 13, 2016

GCE e2e build/test passed for commit 7e51ee1.

@spxtr spxtr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2016
@luxas
Copy link
Member

luxas commented Aug 13, 2016

@ixdy From where in the code is it called?
ref: #26093

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 13, 2016

GCE e2e build/test passed for commit 7e51ee1.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 874a186 into kubernetes:master Aug 13, 2016
@luxas
Copy link
Member

luxas commented Aug 13, 2016

Great, thanks!
It wasn't a kubelet dep then :)

@ixdy ixdy deleted the kubekins-test-bc branch May 15, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants