Validate involvedObject.Namespace matches event.Namespace #30533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/L
|
Re-work of #16146 |
|
cc @derekwaynecarr @lavalamp @feihujiang from earlier related PR |
| // Make sure event.Namespace and the involvedObject.Namespace agree | ||
| if len(event.InvolvedObject.Namespace) == 0 { | ||
| // event.Namespace must also be empty (or "default", for compatibility with old clients) | ||
| if event.Namespace != "" && event.Namespace != api.NamespaceDefault { |
There was a problem hiding this comment.
Use api.NamespaceNone for the empty string.
liggitt
force-pushed
the
event-validation
branch
from
dfb47bf to
5b7edc1
Compare
|
GCE e2e build/test passed for commit 5b7edc1. |
liggitt
added
release-note
smarterclayton
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 5b7edc1. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16036
This change is