SetClientFactory in FederatedInformer #30509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgus
added
retest-not-required
release-note-none
k8s-github-robot
added
the
size/S
|
GCE e2e build/test passed for commit 8dbe762. |
ghost
added
the
priority/important-soon
| @@ -96,6 +96,13 @@ type FederatedInformer interface { | |||
| Stop() | |||
| } | |||
|
|
|||
| // FederatedInformer with extra method for setting fake clients. | |||
There was a problem hiding this comment.
If this is test only, we should have it in test-only dir, so that we are not linking it to production code.
There was a problem hiding this comment.
Discussed offline - let's leave as is for now.
wojtek-t
added
the
lgtm
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unit tests.
cc: @quinton-hoole @wojtek-t @kubernetes/sig-cluster-federation
This change is