Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding e2e test for federation replicasets #30423

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

nikhiljindal
Copy link
Contributor

@nikhiljindal nikhiljindal commented Aug 11, 2016

Its a basic test which tests that we can create and delete replicasets. Will enhance it when we write the replicaset controller.

cc @kubernetes/sig-cluster-federation


This change is Reviewable

@nikhiljindal nikhiljindal changed the title Adding e2e test for replicasets Adding e2e test for federation replicasets Aug 11, 2016
@nikhiljindal nikhiljindal added this to the v1.4 milestone Aug 11, 2016
@nikhiljindal nikhiljindal added area/cluster-federation release-note-none Denotes a PR that doesn't merit a release note. labels Aug 11, 2016
@nikhiljindal
Copy link
Contributor Author

cc @jianhuiz @mwielgus

@nikhiljindal
Copy link
Contributor Author

nikhiljindal commented Aug 11, 2016

The smoke test failure seems to be a flake

Cluster not found

@k8s-bot e2e test this issue: #IGNORE

@fejta fejta assigned mwielgus and unassigned fejta Aug 11, 2016
@nikhiljindal
Copy link
Contributor Author

@mwielgus This is a simple test for verifying that replicasets can be created and deleted with federation-apiserver. This verifies the API code.

Once we have the controller, we can build on this to add more use cases for the controller.
PTAL

@ghost ghost added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 12, 2016
@nikhiljindal
Copy link
Contributor Author

@k8s-bot e2e test this issue: #IGNORE

@nikhiljindal
Copy link
Contributor Author

@mwielgus Can you please take a look?

The test is same as our other tests (federation-event, federation-secret)

@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 18, 2016

GCE e2e build/test passed for commit 4e5e79d.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 18, 2016

GCE e2e build/test passed for commit 4e5e79d.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 793a141 into kubernetes:master Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants