Adding events to federation control plane #30421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/L
nikhiljindal
added
release-note
| @@ -83,4 +83,16 @@ func addConversionFuncs(scheme *runtime.Scheme) { | |||
| panic(err) | |||
| } | |||
| } | |||
| if err := v1.AddFieldLabelConversionsForEvent(scheme); err != nil { | |||
There was a problem hiding this comment.
Any chance you can rebase on top of #25526? I've had to redo it like 5 times...
There was a problem hiding this comment.
Yes sure. Yours is a huge PR! :)
nikhiljindal
force-pushed
the
eventsAPI
branch
2 times, most recently
from
e6ab2f6 to
32c25e5
Compare
|
Updated code as per comments |
k8s-github-robot
added
the
needs-rebase
nikhiljindal
force-pushed
the
eventsAPI
branch
from
32c25e5 to
1d76884
Compare
nikhiljindal
removed
the
needs-rebase
|
Rebased. Ready for another look |
|
GCE e2e build/test passed for commit 1d76884. |
ghost
added
the
priority/backlog
lavalamp
added
the
lgtm
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 1d76884. |
|
Automatic merge from submit-queue |
perotinus
pushed a commit
to kubernetes-retired/cluster-registry
that referenced
this pull request
Sep 2, 2017
Automatic merge from submit-queue Adding events to federation clientset and adding an e2e Fixes kubernetes/kubernetes#27026 events was added to federation-apiserver in kubernetes/kubernetes#30421 cc @kubernetes/sig-cluster-federation @mfanjie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #29744
Adding events to federation control plane.
Apart from the standard changes to add a resource to
federation/apis/core/v1, other changes are:federationoptions.ServerRunOptionswhich includesgenericoptions.ServerRunOptionsand EventsTTL.pkg/api/mapperto build a RestMapper based on the passed Scheme rather than usingapi.Scheme. Updatedfederation/apis/core/installto use this new method. Without this change, iffederation/apis/core/install.init()is called beforepkg/api/install.init()then the registered RESTMapper inpkg/apimachinery/registeredwill have no resources. This second problem will be fixed once we have instances ofpkg/apimachinery/registeredinstead of a single global singleton (generated clientset which importspkg/api/installwill have a different instance of registered, than federation-apiserver which importsfederation/apis/core/install).cc @kubernetes/sig-cluster-federation @lavalamp
This change is