Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GarbageCollector] Let load and density e2e tests use GC if it's on #30401

Merged
merged 1 commit into from
Aug 13, 2016
Merged

[GarbageCollector] Let load and density e2e tests use GC if it's on #30401

merged 1 commit into from
Aug 13, 2016

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Aug 10, 2016 •
edited
Loading

I've run the 100 and 500 nodes tests and they both pass.

The test-infra half of the PR is kubernetes/test-infra#369

cc @lavalamp

This change is Reviewable

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 10, 2016
@caesarxuchao caesarxuchao mentioned this pull request Aug 10, 2016
Merged
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Aug 10, 2016
@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue #IGNORE

gmarek
gmarek reviewed Aug 11, 2016
View reviewed changes
test/e2e/density.go
framework.ExpectNoError(err)
} else {
By("Cleaning up the replication controller and pods")
err := framework.DeleteRC(dtc.Client, dtc.Namespace, rcName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename it to DeleteRCAndPods

@gmarek
Copy link
Contributor

gmarek commented Aug 11, 2016

2 naming nits. LGTM otherwise. GKE test endpoint is down, which causes smoke tests to fail.

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2016
@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue #IGNORE.

@caesarxuchao
Copy link
Member Author

@gmarek I fixed the function names. I'll apply the label myself since the changes are trivial.

@caesarxuchao caesarxuchao added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Aug 11, 2016
@k8s-github-robot
Copy link

@caesarxuchao
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2016
@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2016
@k8s-github-robot
Copy link

@caesarxuchao
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2016
@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2016
@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue #30075

@k8s-bot
Copy link

k8s-bot commented Aug 13, 2016

GCE e2e build/test passed for commit 3688a78.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 817256a into kubernetes:master Aug 13, 2016
@caesarxuchao caesarxuchao mentioned this pull request Aug 13, 2016
Merged
@caesarxuchao caesarxuchao changed the title Let load and density e2e tests use GC if it's on [GarbageCollector] Let load and density e2e tests use GC if it's on Aug 15, 2016
@wojtek-t wojtek-t mentioned this pull request Aug 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caesarxuchao @gmarek @k8s-github-robot @k8s-bot @googlebot