x509 authenticator: get groups from subject's organization field #30392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
force-pushed
the
x509-get-groups-from-org
branch
from
cdc7c75 to
e5d7f01
Compare
k8s-github-robot
added
size/L
| @@ -92,7 +92,10 @@ var CommonNameUserConversion = UserConversionFunc(func(chain []*x509.Certificate | |||
| if len(chain[0].Subject.CommonName) == 0 { | |||
| return nil, false, nil | |||
| } | |||
| return &user.DefaultInfo{Name: chain[0].Subject.CommonName}, true, nil | |||
| return &user.DefaultInfo{ | |||
There was a problem hiding this comment.
@liggitt we have some additional checks in ours and we separate this case from SubjectToUserConversion, but I can't say that I remember why.
liggitt
added
release-note
|
@liggitt this lgtm and I can't remember why we had a separate case instead of |
|
@erictune's point in #30260 (comment) is well taken, though I don't think this would preclude additional server-side groupification |
deads2k
added
the
lgtm
|
GCE e2e build/test passed for commit e5d7f01. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e5d7f01. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the current X509 tests provide a bunch of certs but no private keys or commands to reproduce the testdata, so the new test case isn't added to the certificate chain.
Closes #30260
cc @treed @gtank @mikedanese @deads2k @kubernetes/sig-auth
This change is