Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generators #30387

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Refactor generators #30387

merged 1 commit into from
Aug 11, 2016
+108 −93

Conversation

lavalamp
Copy link
Member

@lavalamp lavalamp commented Aug 10, 2016 •
edited
Loading

Extracting pure refactoring out of #25526 so I don't have to do it for a 4th time.

This makes no changes to the output of the generators.

This change is Reviewable

@lavalamp lavalamp added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 10, 2016
@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 10, 2016
@lavalamp lavalamp mentioned this pull request Aug 10, 2016
Merged
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2016
@lavalamp lavalamp force-pushed the refactor-generators branch from 42489c4 to d7e4028 Compare August 10, 2016 23:59
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 11, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 11, 2016

GCE e2e build/test passed for commit d7e4028.

@wojtek-t
Copy link
Member

LGTM - thanks!

@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed retest-not-required labels Aug 11, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 475f6c5 into kubernetes:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtek-t wojtek-t

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lavalamp @k8s-bot @wojtek-t @k8s-github-robot @googlebot