AWS: Allow no-op kube-down to exit 0 #30380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerlynn
added
retest-not-required
release-note-none
Not exactly sure why hack/e2e.go IsUp() is returning true right now, but I can solve this a different way. This unifies with the GCE behavior, which is that no-op kube-down returns 0.
zmerlynn
force-pushed
the
fix-aws-teardown
branch
from
092c6fc to
8d0200e
Compare
k8s-github-robot
added
the
size/XS
|
lgtm |
justinsb
added
the
lgtm
|
GCE e2e build/test passed for commit 8d0200e. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly sure why hack/e2e.go
IsUp()is returning true right now,but I can solve this a different way. This unifies with the GCE
behavior, which is that no-op kube-down returns 0.
This change is