Federated namespace controller #30207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgus
added
retest-not-required
release-note-none
k8s-github-robot
added
the
size/XL
|
|
||
| type NamespaceController struct { | ||
| // For triggering single namespace reconcilation. This is used when there is an | ||
| // add/update/delete operation on a namespace in ehtier federated API server or |
mwielgus
force-pushed
the
namespace-controller
branch
2 times, most recently
from
6b9e876 to
e5fbbb4
Compare
k8s-github-robot
added
the
needs-rebase
mwielgus
force-pushed
the
namespace-controller
branch
from
e5fbbb4 to
4309021
Compare
k8s-github-robot
added
size/L
mwielgus
force-pushed
the
namespace-controller
branch
from
4309021 to
eaacbd7
Compare
ghost
added
the
k8s-github-robot
added
the
size/XL
| nsClientset := federationclientset.NewForConfigOrDie(restclient.AddUserAgent(restClientCfg, "namespace-controller")) | ||
| namespaceController := namespacecontroller.NewNamespaceController(nsClientset) | ||
| namespaceStopChannel := make(chan struct{}) | ||
| namespaceController.Run(namespaceStopChannel) |
There was a problem hiding this comment.
nit: we are using wait.NeverStop everywhere, so we probably also want it here (no need to create namespaceStopChannel)
|
Just added few more minor comments. Once applied, LGTM |
mwielgus
force-pushed
the
namespace-controller
branch
from
734e9a9 to
74841fa
Compare
k8s-github-robot
added
size/L
mwielgus
added
the
lgtm
…and other minor fixes
mwielgus
force-pushed
the
namespace-controller
branch
from
74841fa to
c1cbe47
Compare
k8s-github-robot
removed
the
lgtm
mwielgus
added
the
lgtm
|
@mwielgus |
k8s-github-robot
removed
the
lgtm
wojtek-t
added
the
lgtm
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit c1cbe47. |
|
Automatic merge from submit-queue |
|
GCE e2e build/test passed for commit c1cbe47. |
justinsb
pushed a commit
to justinsb/kubernetes
that referenced
this pull request
Aug 20, 2016
…-kube-client Automatic merge from submit-queue Federation informer use kube clientset for target This is to use kubernetes clientset as the federation informer target clientset as it's used to talking the k8s cluster. kubernetes#29939 kubernetes#30669 kubernetes#30207 @mwielgus @quinton-hoole @kshafiee @deepak-vij
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented based on federation common libs.
Depends on #30126.
cc: @quinton-hoole @wojtek-t @kubernetes/sig-cluster-federation
This change is