-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an issue template, tighten PR template #30167
Add an issue template, tighten PR template #30167
Conversation
BUG REPORT | ||
---------- | ||
|
||
*Kubernetes version*: (try `kubctl version`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by nit: s/kubctl/kubectl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Is this a request for help (If yes, you should instead post it in StackOverflow, Slack channel, or mailing list, see http://kubernetes.io/docs/troubleshooting/.): What keywords did you search in Kubernetes issues before filing this one (If you found any duplicates, you should instead reply there or use the 👍 icon in the upper-right of the issue message): Is this a BUG REPORT or FEATURE REQUEST (choose one): Kubernetes version (use Environment:
What happened: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else do we need to know: |
59edce0
to
1ac947a
Compare
What this PR does / why we need it: Which issue this PR fixes (optional, in Special notes for your reviewer: Release note:
|
The above is how current issue & PR template looks, major changes include:
|
ff20f6b
to
e867e3a
Compare
@bgrant0607 ptal |
@@ -0,0 +1,47 @@ | |||
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--> | |||
|
|||
**Is this a request for help** (If yes, you should instead post it in StackOverflow, Slack channel, or mailing list, see http://kubernetes.io/docs/troubleshooting/.): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something like: "Is this a request for help (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.)"
Overall this LGTM. |
|
||
**Special notes for your reviewer**: | ||
|
||
**Release note**: | ||
```release-note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could make the syntax clear enough to automatically set the release-note labels based on the text here.
All comments addressed, @philips @bgrant0607 ptal |
LGTM |
I looked at a few other examples of templates and tried to make ours more succint and helpful. Feedback is welcome.
afd98a6
to
de91512
Compare
Squashed; applying tag |
GCE e2e build/test passed for commit de91512. |
Automatic merge from submit-queue |
Supersedes #28488
This change is