Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use format instead of awk to extract active account/project #30008

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Use format instead of awk to extract active account/project #30008

merged 1 commit into from
Aug 3, 2016

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Aug 3, 2016

gcloud changed the format of the output from active to ACTIVE

@fejta fejta added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Aug 3, 2016
@fejta fejta assigned spxtr and ixdy Aug 3, 2016
@fejta fejta added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. and removed cla: yes priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 3, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2016
@fejta
Copy link
Contributor Author

fejta commented Aug 3, 2016

@k8s-bot node e2e test this issue #30009

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2016
@fejta
Copy link
Contributor Author

fejta commented Aug 3, 2016

@k8s-bot e2e test this issue #30009

@spxtr
Copy link
Contributor

spxtr commented Aug 3, 2016 

$ git grep "gcloud .* | awk"
build/common.sh:    GCLOUD_ACCOUNT=$(gcloud auth list 2>/dev/null | awk '/(active)/ { print $2 }')
build/common.sh:    GCLOUD_PROJECT=$(gcloud config list project | awk '{project = $3} END {print project}')
examples/openshift-origin/README.md:$ export ZONE=$(gcloud compute instances list | grep "${KUBE_GCE_INSTANCE_PREFIX}\-master" | awk '{print $2}' | head -1)
examples/openshift-origin/create.sh:export ZONE=$(gcloud compute instances list | grep "${KUBE_GCE_INSTANCE_PREFIX}\-master" | awk '{print $2}' | head -1)
$ git grep "gcloud .* | grep"
build/common.sh:  if [[ -n $(gcloud auth list --filter-account $account 2>/dev/null | grep "active") ]]; then
examples/openshift-origin/README.md:$ export ZONE=$(gcloud compute instances list | grep "${KUBE_GCE_INSTANCE_PREFIX}\-master" | awk '{print $2}' | head -1)
examples/openshift-origin/README.md:$ echo "sudo cat /srv/kubernetes/server.key; exit;" | gcloud compute ssh ${KUBE_GCE_INSTANCE_PREFIX}-master --zone ${ZONE} | grep -Ex "(^\-.*\-$|^\S+$)" > ${OPENSHIFT_CONFIG}/serviceaccounts.private.key
examples/openshift-origin/create.sh:gcloud_instances=$(gcloud compute instances list | grep "\-master")
examples/openshift-origin/create.sh:export ZONE=$(gcloud compute instances list | grep "${KUBE_GCE_INSTANCE_PREFIX}\-master" | awk '{print $2}' | head -1)
examples/openshift-origin/create.sh:echo "sudo cat /srv/kubernetes/server.key; exit;" | gcloud compute ssh ${KUBE_GCE_INSTANCE_PREFIX}-master --zone ${ZONE} | grep -Ex "(^\-.*\-$|^\S+$)" > ${OPENSHIFT_CONFIG}/serviceaccounts.private.key
examples/storage/vitess/configure.sh:  project=$(gcloud config list project | grep 'project\s*=' | sed -r 's/^.*=\s*(.*)$/\1/')
hack/make-rules/test-e2e-node.sh:  gcloud compute images list --project="${image_project}" | grep "e2e-node"
hack/make-rules/test-e2e-node.sh:         if [[ $(gcloud compute instances list "${instance_prefix}-$i" | grep $i) ]]; then
test/e2e/restart.go://    output=$(gcloud compute instance-groups managed --zone="${ZONE}" get-operation ${op} | grep status)

@k8s-bot
Copy link

k8s-bot commented Aug 3, 2016

GCE e2e build/test passed for commit add6feb.

@lavalamp
Copy link
Member

lavalamp commented Aug 3, 2016

[build cop merge to unbreak head]

@lavalamp lavalamp merged commit 8f4f682 into kubernetes:master Aug 3, 2016
@fejta fejta deleted the gke branch August 3, 2016 20:00
This was referenced Aug 3, 2016
Closed
Merged
@fabioy fabioy added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Aug 5, 2016
@fabioy fabioy added this to the v1.3 milestone Aug 5, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@fabioy
Copy link
Contributor

fabioy commented Aug 5, 2016

@fejta I think we'll need this for the 1.3 branch as well. Could you create a cherrypick PR as well? Thanks.

@fejta fejta mentioned this pull request Aug 5, 2016
Merged
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@ixdy
Copy link
Member

ixdy commented Aug 11, 2016

Do we care about building on release-1.2? Cause it's similarly broken.

@ixdy ixdy mentioned this pull request Aug 18, 2016
Merged
roberthbailey added a commit that referenced this pull request Sep 9, 2016
@roberthbailey
Merge pull request #30942 from ixdy/automated-cherry-pick-of-#30008-#…
d15c663 
…30479-upstream-release-1.2

Automated cherry pick of #30008 #30479
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@roberthbailey
Merge pull request kubernetes#30942 from ixdy/automated-cherry-pick-o…
e715fce 
…f-#30008-kubernetes#30479-upstream-release-1.2

Automated cherry pick of kubernetes#30008 kubernetes#30479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@ixdy ixdy

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
9 participants
@fejta @spxtr @k8s-bot @lavalamp @k8s-cherrypick-bot @fabioy @ixdy @googlebot @k8s-github-robot