Fix PVC.Status.Capacity and AccessModes after binding #29982
Merged
+114
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsafrane
added
sig/storage
k8s-github-robot
added
the
size/L
| glog.V(4).Infof("updating PersistentVolumeClaim[%s]: phase %s already set", claimToClaimKey(claim), phase) | ||
| return claim, nil | ||
| } | ||
| // updateClaimStatusWithEvent saves new claim.Status to API server. |
There was a problem hiding this comment.
updateClaimStatus not updateClaimStatusWithEvent
There was a problem hiding this comment.
Please add comment explaining what the parameters are and how they are used.
jsafrane
force-pushed
the
fix-claim-status-capacity
branch
from
ea3a56e to
a2cd876
Compare
|
LGTM |
|
Please squash commits and add LGTM label |
saad-ali
added
release-note
Also, fix unit tests to have the same claim and volume sizes in most of the tests where we don't test matching based on size and test for a specific size when we do actually test the matching.
jsafrane
force-pushed
the
fix-claim-status-capacity
branch
from
a2cd876 to
3c53649
Compare
|
squashed and pushed |
jsafrane
added
the
lgtm
|
GCE e2e build/test passed for commit 3c53649. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 3c53649. |
|
Automatic merge from submit-queue |
|
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#29982-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#29982 Cherry pick of kubernetes#29982 on release-1.3.
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ck-of-#29982-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#29982 Cherry pick of kubernetes#29982 on release-1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix unit tests to have the same claim and volume sizes in most of the
tests where we don't test matching based on size and test for a specific size
when we do actually test the matching.
Fixes #29425