Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Libcontainer to latest head #29928

Merged
merged 2 commits into from
Aug 4, 2016

Conversation

dubstack
Copy link

@dubstack dubstack commented Aug 2, 2016

@Random-Liu or @yujuhong Can any one of you please do a quick review.

I updated libcontainer in a previous PR but #29492 reverted those changes. This is needed for #27204.

Signed-off-by: Buddha Prakash buddhap@google.com

@dubstack dubstack added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 2, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 2, 2016
@dubstack dubstack added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2016
@dubstack
Copy link
Author

dubstack commented Aug 2, 2016

I will be adding a second commit with changes in Kubernetes codebase.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 2, 2016
@Random-Liu
Copy link
Member

@dubstack Test is failing.

@dubstack
Copy link
Author

dubstack commented Aug 2, 2016

I will adding one more commit to add changes in kubernetes. I think the kubelet would also benefit from some refactoring. So i am working on that

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2016
@dubstack dubstack force-pushed the bump-libcontainer branch from f7253be to 569aecd Compare August 4, 2016 16:01
@dubstack dubstack added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Aug 4, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2016
@dubstack dubstack assigned Random-Liu and vishh and unassigned thockin Aug 4, 2016
@dubstack
Copy link
Author

dubstack commented Aug 4, 2016

@Random-Liu @vishh PTAL.

@dubstack dubstack force-pushed the bump-libcontainer branch from 569aecd to 49201f6 Compare August 4, 2016 17:06
@k8s-bot
Copy link

k8s-bot commented Aug 4, 2016

GCE e2e build/test passed for commit 49201f6.

@yujuhong
Copy link
Contributor

yujuhong commented Aug 4, 2016

PR LGTM.

@vishh
Copy link
Contributor

vishh commented Aug 4, 2016

LGTM

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2016
@vishh vishh added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 4, 2016
@vishh
Copy link
Contributor

vishh commented Aug 4, 2016

Bumping priority since three other PRs are dependent on this.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 4, 2016

GCE e2e build/test passed for commit 49201f6.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d10e47b into kubernetes:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants