Enable PodAffinity by default in scheduler #29912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
added
the
release-note-none
k8s-github-robot
added
the
size/M
wojtek-t
added
the
do-not-merge
|
I would like to profile it a bit more before we merge it, so applying "do-not-merge" label for now. |
|
OK - so I did some more experiments and scheduler throughput it slightly worse with this PR, but the difference is acceptable in my opinion. I think we should go with it, and optimize when needed. @davidopp - PTAL |
wojtek-t
removed
the
do-not-merge
davidopp
added
the
lgtm
|
LGTM |
|
GCE e2e build/test passed for commit b68905b. |
timothysc
added
the
sig/scheduling
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit b68905b. |
|
Automatic merge from submit-queue |
|
/cc @smarterclayton fyi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #26144
@gmarek - FYI