[kubelet] Auto-discover node IP if neither cloud provider exists and IP is not explicitly specified #29907
+30
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this worthy a release note? |
k8s-github-robot
added
size/M
|
GCE e2e build/test passed for commit 25d9779. |
|
@k8s-bot node_e2e test this please github issue: #IGNORE |
|
@k8s-bot node e2e test this please github issue: #IGNORE |
|
This LGTM. Thanks for the cleanup @luxas |
|
lgtm |
vishh
changed the title
|
@luxas I updated the PR title to make it suitable for release notes. PTAL |
luxas
changed the title
|
Great! Seems like the auto-lgtm-bot isn't active yet, so adding I'm the labels now |
luxas
added
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 25d9779. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One example where the earlier implementation failed is when running kubelet on CoreOS (bare-metal), where the nameserver is set to
8.8.8.8. kubelet tries to lookup the node name agains Google DNS, which obviously fails. The kubelet won't recover after that.The workaround hsa been to set
--hostname-overrideto an IP address, but it's quite annoying to try to make a multi-distro way of getting the IP in bash for example. This way is much cleaner.Refactored the function a little bit at the same time
@vishh @yujuhong @resouer @Random-Liu