Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/delete cluster, delete context to kubectl config #29821

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Add get/delete cluster, delete context to kubectl config #29821

merged 1 commit into from
Aug 26, 2016

Conversation

alexbrand
Copy link
Contributor

@alexbrand alexbrand commented Jul 30, 2016

Fixes #29794 by adding get-clusters, delete-cluster and delete-context actions to kubectl config.


This change is Reviewable

@k8s-bot
Copy link

k8s-bot commented Jul 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

3 similar comments
@k8s-bot
Copy link

k8s-bot commented Jul 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Jul 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Jul 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jul 30, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@j3ffml
Copy link
Contributor

j3ffml commented Aug 1, 2016

@k8s-bot ok to test

@j3ffml j3ffml changed the title Add get/delete cluster, delete context to kubectl Add get/delete cluster, delete context to kubectl config Aug 1, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Aug 1, 2016

You'll need to run hack/update-generated-docs.sh, but otherwise looks good. cc @janetkuo @bgrant0607

@alexbrand
Copy link
Contributor Author

@jlowdermilk Running hack/update-generated-docs.sh doesn't result in any changed files according to git. Am I doing something wrong?

@j3ffml
Copy link
Contributor

j3ffml commented Aug 1, 2016

@alexbrand it may rely on having the repository in your gopath. You can do that by making a symlink to your local repo at $GOPATH/src/github.com/kubernetes. Also, try running the verify check locally to see what it suggests.

@alexbrand
Copy link
Contributor Author

@jlowdermilk Updated docs. Thanks!

@k8s-github-robot k8s-github-robot added kind/old-docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Aug 1, 2016

I'm apparently out of date on how we actually bump kubectl docs. @janetkuo what's the new procedure?

@j3ffml j3ffml added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 2, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Aug 2, 2016

@alexbrand I believe generated docs are now good (sorry for confusion, we're apparently changing how we update them #26205), but looks like unit tests are failing.

@j3ffml
Copy link
Contributor

j3ffml commented Aug 2, 2016

cc @kubernetes/kubectl

@alexbrand
Copy link
Contributor Author

Thanks @jlowdermilk. I'll take a look as soon as I can.

@k8s-bot
Copy link

k8s-bot commented Aug 11, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@janetkuo
Copy link
Member

ok to test

@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@j3ffml
Copy link
Contributor

j3ffml commented Aug 17, 2016

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@j3ffml
Copy link
Contributor

j3ffml commented Aug 20, 2016

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Aug 21, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@j3ffml
Copy link
Contributor

j3ffml commented Aug 22, 2016

Adding label. @janetkuo please remove if you see anything.

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2016
@lavalamp lavalamp modified the milestones: v1.5, v1.4 Aug 23, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Aug 26, 2016

@k8s-bot test this issue: #31462

@k8s-bot
Copy link

k8s-bot commented Aug 26, 2016

GCE e2e build/test passed for commit 82c700c.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 26, 2016

GCE e2e build/test passed for commit 82c700c.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@erictune
Copy link
Member

@alexbrand Thanks! I am going to try this out right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants