Use latest GCI image based on a regex in Node e2e #29815
Conversation
vishh
added
the
release-note-none
k8s-github-robot
added
the
size/L
|
@Random-Liu can you review this now? I will fix the test failure some time soon. The rest of the PR is ready to go |
vishh
force-pushed
the
node-e2e-latest-gci
branch
2 times, most recently
from
28006a0 to
73e378f
Compare
|
@Random-Liu I suspect that this change will reduce the flakiness for node e2e. Can you review this patch soon? |
k8s-github-robot
added
the
needs-rebase
| @@ -126,7 +129,7 @@ if [ $remote = true ] ; then | |||
| echo "Ginkgo Flags: $ginkgoflags" | |||
| echo "Instance Metadata: $metadata" | |||
| # Invoke the runner | |||
| go run test/e2e_node/runner/run_e2e.go --logtostderr --vmodule=*=2 --ssh-env="gce" \ | |||
| go run test/e2e_node/runner/run_e2e.go --logtostderr --vmodule=*=4 --ssh-env="gce" \ | |||
There was a problem hiding this comment.
Just make sure. If this on purpose or changed during debugging? :)
There was a problem hiding this comment.
I did change it on purpose. Otherwise debugging jenkins failures are difficult.
|
LGTM with a few questions. Please rebase. |
| - mount /tmp /tmp -o remount,exec,suid | ||
| - ETCD_VERSION=v2.2.5 | ||
| - curl -L https://github.com/coreos/etcd/releases/download/${ETCD_VERSION}/etcd-${ETCD_VERSION}-linux-amd64.tar.gz -o /tmp/etcd.tar.gz | ||
| - mount tmpfs /tmp -o remount,exec,suid |
There was a problem hiding this comment.
Just for my education. What is the difference between mount /tmp /tmp and mount tmpfs /tmp? GCI is not using tmpfs by default?
There was a problem hiding this comment.
No difference. I reverted this change to be safe.
It can run tests against multiple existing images that match a regex. GCI images will be using a regex. Signed-off-by: Vishnu kannan <vishnuk@google.com>
Signed-off-by: Vishnu kannan <vishnuk@google.com>
vishh
force-pushed
the
node-e2e-latest-gci
branch
from
73e378f to
e9034f1
Compare
k8s-github-robot
removed
the
needs-rebase
|
@Random-Liu rebased PTAL. |
|
GCE e2e build/test passed for commit e9034f1. |
vishh
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e9034f1. |
|
Automatic merge from submit-queue |
…ional Automatic merge from submit-queue node e2e script: call 'gcloud compute' only if necessary **What this PR does / why we need it**: The ``gcloud compute`` is called everytime even if it is not needed. When runnin node e2e tests on RHEL, the test-e2e-node.sh script is run the way in which it takes execution path without ``gcloud`` invocation. With the current code, ``gcloud`` is called everytime. Thus introducing additional runtime dependency. **Special notes for your reviewer**: First introduced here: #29815
This PR also makes it possible to run node e2e against multiple previous images, sorted by creation time. A regex for the image name can be used to instruct node e2e to identify test images.
Depends on #29577
This change is