-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token review endpoint #29796
Token review endpoint #29796
Conversation
@deads2k - I wasn't involved in fixing it, to please don't block on me at all. |
@deads2k We're still working on the actual relaxation of field checking. As a workaround, I can shove all of the added fields into our server's expected request body, but that's really gross. I know this is holding you guys up right now, so I'll have an answer early next week. |
Thanks. I suspect we'll have a similar problem in #20573 when I rebase that one. |
78982dc
to
39c3607
Compare
d93d8b8
to
c009a9a
Compare
kicking tests now that #29375 is resolved. |
GKE tests look to be fixed, smoke test passed with matching levels, #28788 was already tagged, so applying the tag here. The release note was done for the original pull that was reverted |
Sorry @deads2k this is still broken on our side. I'm trying to get the fix pushed out today, but GKE smoke tests still don't quite test the same config as gke-ci. |
Yikes! Is there another issue I can watch? I saw the existing one get resolved. |
Thanks, once that's merged, I just have to rekick the tests and this and #20573 will be safe? |
Now that that's merged, the GKE smoke tests should fail for both this and #20573... Once I get my GKE server side change rolled out (hopefully soonish today), then GKE smoke tests will start passing for you and I can get out of your way 😃 |
This should be unblocked on our end now. I just manually tested a kubernetes CI build with this change ( 1.4.0-alpha.1.564+8ead63f1270455) and confirmed that authentication is working. I'm attempting to kick GKE smoke tests just to verify. |
@k8s-bot e2e test this issue #IGNORE |
GCE e2e build/test passed for commit d505063. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit d505063. |
Automatic merge from submit-queue |
Our 6:00 PM automatic deployment pushed a slightly too-old build to our test endpoint, so this is going to appear to have broken things again until I get a fixed build back live... 😒 |
@cjcullen - it seems that we hit this also in staging: When do you think it will be fixed? |
@wojtek-t 😞 I didn't realize we had any CI running against our staging endpoint. I'll work on getting an updated build pushed out to staging today. |
Unrevert of #28788, which was rolled back because of #29375
@cjcullen @wojtek-t I'd like to remerge if possible. Have we gotten the field checking mentioned here relaxed? #28788 (comment)