e2e-runner: Remove quotes from jq output #29787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent GCI e2e test failures suggest that the image name was double quoted when passed to gcloud. E.g., ``` 09:59:51 - Invalid value for field 'resource.disks[0].initializeParams.sourceImage': 'https://www.googleapis.com/compute/v1/projects/container-vm-image-staging/global/images/"gci-base-53-8530-36-0"'. The referenced image resource cannot be found. ``` The `-r`, or `--raw-output` option strips quotes from jq's output. With this change, the output looks like: ``` + export KUBE_GCE_MASTER_IMAGE=gci-base-54-8650-0-0 # Not quoted ```
k8s-github-robot
added
size/XS
spxtr
added
lgtm
Agreed. |
|
GCE e2e build/test passed for commit e4cfb91. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e4cfb91. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent GCI e2e test failures suggest that the image name was double quoted when
passed to gcloud. E.g.,
The
-r, or--raw-outputoption strips quotes from jq's output. With thischange, the output looks like:
@spxtr Can you review this XS PR? All of our e2e jobs are failing due to this.
Also, this was a bug introduced by #29631. I tried several times to duplicate the Kubekins instance locally, but still couldn't get it running. It would be GREAT if Jenkins changes can be tested before getting merged. :)