Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error reporting during vagrant provisioning #29610

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Fix error reporting during vagrant provisioning #29610

merged 1 commit into from
Aug 10, 2016

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Jul 26, 2016 •
edited by k8s-oncall
Loading

release_not_found shell function can be used both while running
provision-master.sh and privision-node.sh (it's used by install-salt
function in provision-utils.sh, but it was defined in provision-master.sh.
Because of this, one of my colleagues got the following diagnostic:

==> master: Succeeded: 52 (changed=8)
==> master: Failed:     0
==> master: -------------
==> master: Total states run:     52
==> node-1: Machine already provisioned. Run `vagrant provision` or use the `--provision`
==> node-1: flag to force provisioning. Provisioners marked to run always will still run.
==> node-1: Running provisioner: shell...
    node-1: Running: /tmp/vagrant-shell20160726-19144-hahnl1.sh
==> node-1: Prepare package manager
==> node-1: Provisioning network on node
==> node-1: Network configuration verified
==> node-1: /tmp/vagrant-shell: line 134: release_not_found: command not found
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

... which is rather confusing.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 26, 2016
@jellonek
Copy link
Contributor

Bump up.

@ivan4th ivan4th mentioned this pull request Jul 28, 2016
Merged
@derekwaynecarr
Copy link
Member

Thanks for the fix.

@derekwaynecarr derekwaynecarr added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 5, 2016
@derekwaynecarr derekwaynecarr added this to the v1.4 milestone Aug 5, 2016
@derekwaynecarr
Copy link
Member

@k8s-bot test this issue #29992

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2016
@ivan4th
Copy link
Contributor Author

ivan4th commented Aug 5, 2016

Hmm, obviously e2e test failures have nothing todo with vagrant provisioning here...

@ivan4th
Copy link
Contributor Author

ivan4th commented Aug 8, 2016

@derekwaynecarr (ping) can we re-test this? The e2e test failure doesn't involve vagrant provider at all

@derekwaynecarr
Copy link
Member

@k8s-bot test this issue #30124

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

GCE e2e build/test passed for commit 3e35949.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit cbe75f4 into kubernetes:master Aug 10, 2016
@ivan4th ivan4th deleted the fix-vagrant-provision-error branch August 11, 2016 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ivan4th @jellonek @derekwaynecarr @k8s-bot @k8s-github-robot @googlebot