Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #24385 #29485 upstream release 1.3 #29570

Conversation

saad-ali
Copy link
Member

Cherry pick PR #29485 ("Assume volume is detached if node doesn't exist") and dependent PR #24385 ("golint fixes for AWS cloudprovider") to upstream release 1.3

CC @justinsb

@saad-ali saad-ali added this to the v1.3 milestone Jul 25, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@saad-ali
Copy link
Member Author

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@therc Since you are the original author of #24385, can you please confirm.

@therc
Copy link
Member

therc commented Jul 25, 2016

I'm not sure why you need my confirmation since it's already in master, but it's OK to commit this change. Thanks!

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Jul 25, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 25, 2016

GCE e2e build/test passed for commit 1bc5468.

@fabioy fabioy added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 26, 2016
@fabioy fabioy merged commit edfa5ae into kubernetes:release-1.3 Jul 26, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@saad-ali saad-ali deleted the automated-cherry-pick-of-#24385-#29485-upstream-release-1.3 branch August 15, 2016 22:23
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ck-of-#24385-kubernetes#29485-upstream-release-1.3

Automated cherry pick of kubernetes#24385 kubernetes#29485 upstream release 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants