Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #28153 #28409 #28939 upstream release 1.3 #29569

Merged
merged 3 commits into from
Jul 28, 2016
Merged

Automated cherry pick of #28153 #28409 #28939 upstream release 1.3 #29569

merged 3 commits into from
Jul 28, 2016

Conversation

saad-ali
Copy link
Member

Cherry pick PR #28939 ("Allow mounts to run in parallel for non-attachable volumes") and dependent PRs #28153 () and #28409 to upstream release 1.3

@saad-ali saad-ali added this to the v1.3 milestone Jul 25, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@saad-ali
Copy link
Member Author

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@jsafrane Since you are the original author of #28153, can you please confirm.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jul 25, 2016
@saad-ali
Copy link
Member Author

Looks like there was a merge issue with this cherry pick. Taking a look.

@saad-ali saad-ali force-pushed the automated-cherry-pick-of-#28153-#28409-#28939-upstream-release-1.3 branch 2 times, most recently from c6470dc to 0ffcad4 Compare July 25, 2016 23:32
@saad-ali
Copy link
Member Author

Merge issue resolved. Ready to review

@fabioy fabioy added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 26, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 26, 2016

@jsafrane Cherrypick approved. Please resolve the cla issue. Thanks.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2016
@erinboyd
Copy link

The Red Hat CLA covers this PR

@saad-ali
Copy link
Member Author

Thanks @erinboyd. @fabioy I will rebase the PR.

@fabioy fabioy added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 26, 2016
@saad-ali saad-ali force-pushed the automated-cherry-pick-of-#28153-#28409-#28939-upstream-release-1.3 branch from 0ffcad4 to 57f7207 Compare July 27, 2016 19:15
@saad-ali saad-ali removed the cla: no label Jul 27, 2016
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2016
@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2016
jsafrane and others added 2 commits July 27, 2016 20:24
@jsafrane @saad-ali
Fixed goroutinemap race on Wait()
1b5abb7 
sync.WaitGroup produces data races when a GoroutineMap is empty and Wait() and
Run() are called at the same time.

From sync.WaitGroup:
   Note that calls with a positive delta that occur when the counter is zero
   must happen before a Wait.

Fixes kubernetes#28128
@saad-ali
Reorganize volume controllers and manager
f063884
@saad-ali saad-ali force-pushed the automated-cherry-pick-of-#28153-#28409-#28939-upstream-release-1.3 branch from 57f7207 to 0b2d1ff Compare July 28, 2016 03:27
@saad-ali saad-ali removed the cla: no label Jul 28, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2016
@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2016
@saad-ali
Copy link
Member Author

Readding LGTM after rebase

@saad-ali
Allow mounts to run in parallel for non-attachable
942bc8a 
Allow mount volume operations to run in parallel for non-attachable
volume plugins.

Allow unmount volume operations to run in parallel for all volume
plugins.
@saad-ali saad-ali force-pushed the automated-cherry-pick-of-#28153-#28409-#28939-upstream-release-1.3 branch from 0b2d1ff to 942bc8a Compare July 28, 2016 04:08
@saad-ali saad-ali added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: no lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 28, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 28, 2016

GCE e2e build/test passed for commit 942bc8a.

@fabioy fabioy merged commit 3b64465 into kubernetes:release-1.3 Jul 28, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

This was referenced Aug 1, 2016
Closed
Merged
@saad-ali saad-ali deleted the automated-cherry-pick-of-#28153-#28409-#28939-upstream-release-1.3 branch August 15, 2016 22:23
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@fabioy
Merge pull request kubernetes#29569 from saad-ali/automated-cherry-pi…
12aa578 
…ck-of-#28153-kubernetes#28409-kubernetes#28939-upstream-release-1.3

Automated cherry pick of kubernetes#28153 kubernetes#28409 kubernetes#28939 upstream release 1.3
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@fabioy
Merge pull request kubernetes#29569 from saad-ali/automated-cherry-pi…
f391d0c 
…ck-of-#28153-kubernetes#28409-kubernetes#28939-upstream-release-1.3

Automated cherry pick of kubernetes#28153 kubernetes#28409 kubernetes#28939 upstream release 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabioy fabioy

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
8 participants
@saad-ali @googlebot @fabioy @erinboyd @k8s-github-robot @k8s-bot @k8s-cherrypick-bot @jsafrane