-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quota was not counting services with multiple nodeports properly #29457
Quota was not counting services with multiple nodeports properly #29457
Conversation
looks like i missed a unit test, will update. |
e7b2827
to
305411b
Compare
Fixed other unit test. |
@derekwaynecarr |
GCE e2e build/test passed for commit 305411b. |
Automatic merge from submit-queue |
@ncdc @derekwaynecarr @bprashanth I believe services of type LoadBalancer also allocate nodePorts. The ServiceUsageFunc (https://github.com/kubernetes/kubernetes/blob/master/pkg/quota/evaluator/core/services.go#L72) only accounts for nodePorts when type=NodePort.
|
@girishkalele - can you open an issue with a sample LoadBalancer service and I will provide a fix? |
Thanks - filed #32221 |
Fixes #29456
/cc @kubernetes/rh-cluster-infra @sdminonne