Make Swagger API support optional, so that consumers can define their own #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… own OpenShift would like to also enable swagger, but we need to register our services as swagger services prior to the SwaggerAPI being started. I've added a bool (default false) to master.Config to enable swagger, and split the method in master out so that a downstream consumer can call it.
| @@ -69,11 +69,15 @@ type Config struct { | |||
| PortalNet *net.IPNet | |||
| EnableLogsSupport bool | |||
| EnableUISupport bool | |||
| EnableSwaggerSupport bool | |||
There was a problem hiding this comment.
Didn't you want to be able to configure the path at which it's exposed, also?
There was a problem hiding this comment.
It actually turned out better to be the same. If necessary we can tweak the swagger config in our own code - I exposed the method for now though.
----- Original Message -----
@@ -69,11 +69,15 @@ type Config struct {
PortalNet *net.IPNet
EnableLogsSupport bool
EnableUISupport bool
- EnableSwaggerSupport bool
Didn't you want to be able to configure the path at which it's exposed, also?
Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/pull/2945/files#r21854923
|
LGTM. |
|
Waiting for Travis. |
bgrant0607
added a commit
that referenced
this pull request
Dec 16, 2014
Make Swagger API support optional, so that consumers can define their own
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift would like to also enable swagger, but we need to register our
services as swagger services prior to the SwaggerAPI being started. I've
added a bool (default false) to master.Config to enable swagger, and split
the method in master out so that a downstream consumer can call it.
No functional change for Kube, just more master flexibility.