kube-up: increase download timeout for kubernetes.tar.gz #29426
Conversation
Particularly on smaller instances on AWS, we were hitting the 80 second timeout now that our image is well over the 1GB mark. Increase the timeout from 80 seconds to 300 seconds. Fix kubernetes#29418
justinsb
added
release-note-none
|
Not sure how we currently mark this for cherrypick, but I think we'll want to cherrypick this to 1.3 |
|
Removing label |
k8s-github-robot
added
the
size/XS
|
GCE e2e build/test passed for commit eb3483e. |
| @@ -166,7 +166,7 @@ download-or-bust() { | |||
| for url in "${urls[@]}"; do | |||
| local file="${url##*/}" | |||
| rm -f "${file}" | |||
| if ! curl -f --ipv4 -Lo "${file}" --connect-timeout 20 --max-time 80 --retry 6 --retry-delay 10 "${url}"; then | |||
| if ! curl -f --ipv4 -Lo "${file}" --connect-timeout 20 --max-time 300 --retry 6 --retry-delay 10 "${url}"; then | |||
There was a problem hiding this comment.
are either of these files used in aws?
There was a problem hiding this comment.
configure-vm definitely is: https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/configure-vm.sh#L21
I was thinking about this though...
1.5 GB in 80 seconds is about 20 MB/second. 300 seconds is about 5 MB / second. I would argue we probably shouldn't treat anything over 1MB/s as an error, but a 1500 second timeout just feels ridiculous. The right answer is to make the download smaller (or skip it entirely), but in the meantime...
mikedanese
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit eb3483e. |
|
Automatic merge from submit-queue |
fabioy
added
the
cherry-pick-approved
|
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
…ck-of-#29426-origin-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#29426 Cherry pick of kubernetes#29426 on release-1.3.
Particularly on smaller instances on AWS, we were hitting the 80 second
timeout now that our image is well over the 1GB mark.
Increase the timeout from 80 seconds to 300 seconds.
Fix #29418