Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #29316 #29414

Conversation

ronnielai
Copy link
Contributor

Cherry pick of #29316 on release-1.3.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2016
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@fabioy fabioy added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jul 22, 2016
@fabioy fabioy added this to the v1.3 milestone Jul 22, 2016
@ronnielai ronnielai force-pushed the automated-cherry-pick-of-#29316-upstream-release-1.3 branch from 6c13678 to bd95903 Compare July 22, 2016 01:23
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2016
@ronnielai ronnielai added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2016
@ronnielai
Copy link
Contributor Author

ronnielai commented Jul 22, 2016

Reapply LGTM after fixing incorrect merging fix (extra methods were pulled in).

@ronnielai ronnielai force-pushed the automated-cherry-pick-of-#29316-upstream-release-1.3 branch from bd95903 to 016937a Compare July 22, 2016 01:49
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2016
@ronnielai ronnielai added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 22, 2016

GCE e2e build/test passed for commit 016937a.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 22, 2016

GCE e2e build/test passed for commit 016937a.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9cbd706 into kubernetes:release-1.3 Jul 22, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@fabioy fabioy added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 22, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ick-of-#29316-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of kubernetes#29316

Cherry pick of kubernetes#29316 on release-1.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants