fix e2e for all providers except gce #2936
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
brendandburns
added a commit
that referenced
this pull request
Dec 15, 2014
fix e2e for all providers except gce
|
@satnam6502 please take a look at this. We need to make sure not to break non-GCE e2e. Thanks for the fix (and sorry for the break!) |
|
Noted, and sorry for the breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colors aren't present for any provider other than GCE. Move the color definition to kube-env.sh so that everyone has them.
@derekwaynecarr vagrant environments are broken until the color definitions are present.