Removing images with multiple tags #29316
Merged
+72
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronnielai
added
the
release-note-none
k8s-github-robot
added
size/L
ronnielai
force-pushed
the
docker-image-remove
branch
2 times, most recently
from
10bd67c to
c44df3c
Compare
k8s-github-robot
removed
the
needs-rebase
|
Looks good to me 👍 |
| @@ -45,7 +45,7 @@ import ( | |||
| func verifyCalls(t *testing.T, fakeDocker *FakeDockerClient, calls []string) { | |||
| fakeDocker.Lock() | |||
| defer fakeDocker.Unlock() | |||
| verifyStringArrayEquals(t, fakeDocker.called, calls) | |||
| verifyStringArrayEquals(t, fakeDocker.getCalledNames(), calls) | |||
There was a problem hiding this comment.
Change this to use AssertCalls?
|
LGTM with a nit. |
ronnielai
force-pushed
the
docker-image-remove
branch
from
c44df3c to
e25da21
Compare
|
LGTM. Feel free to apply the label after the test passes. :) |
|
GCE e2e build/test passed for commit e25da21. |
ronnielai
added
lgtm
ronnielai
added
the
priority/critical-urgent
|
Bumped to P0 to be cherry-picked to 1.3 |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e25da21. |
|
Automatic merge from submit-queue |
fabioy
added
the
cherry-pick-approved
fabioy
removed
the
cherry-pick-approved
fabioy
added
release-note
This was referenced Sep 30, 2016
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 12, 2016
Automatic merge from submit-queue CRI: Image pullable support in dockershim For #33189. The new test `ImageID should be set to the manifest digest (from RepoDigests) when available` introduced in #33014 is failing, because: 1) `docker-pullable://` conversion is not supported in dockershim; 2) `kuberuntime` and `dockershim` is using `ListImages with image name filter` to check whether image presents. However, `ListImages` doesn't support filter with `digest`. This PR: 1) Change `kuberuntime.IsImagePresent` to use `runtime.ImageStatus` and `dockershim.InspectImage` instead. ***Notice an API change: `ImageStatus` should return `(nil, nil)` for non-existing image.*** 2) Add `docker-pullable://` support. 3) Fix `RemoveImage` in dockershim #29316. I've tried myself, the test can pass now. @yujuhong @feiskyer @yifan-gu /cc @kubernetes/sig-node
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ick-of-#29316-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#29316 Cherry pick of kubernetes#29316 on release-1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an image has multiple tags, we need to remove all the tags in order to make docker image removing successful.
#28491