Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #29071 upstream release 1.3 #29313

Conversation

ericchiang
Copy link
Contributor

RBAC authorizer assigns a role to a wrong service account.

RBAC authorizer assigns a role to a wrong service account.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 20, 2016
@ericchiang
Copy link
Contributor Author

@kubernetes/sig-auth any idea how I do this cherry pick properly?

@deads2k
Copy link
Contributor

deads2k commented Jul 22, 2016

@kubernetes/sig-auth any idea how I do this cherry pick properly?

@derekwaynecarr Any special tags he needs?

@fabioy fabioy added this to the v1.3 milestone Jul 26, 2016
@fabioy fabioy added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed release-note-label-needed labels Jul 26, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 26, 2016

@ericchiang For future reference, please add "cherrypick-candidate" to PR to be considered.
@albatross0 Please confirm you're ok with this PR so I can resolve cla (sorry, you have to give explicit approval).

@albatross0
Copy link
Contributor

OK. Here you go.

@fabioy fabioy added cla: human-approved lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: no do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 26, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 26, 2016

GCE e2e build/test passed for commit beed98b.

@ericchiang
Copy link
Contributor Author

CLA check is still unhappy. Is there a specific phrase you have to use to grant consent?

@liggitt
Copy link
Member

liggitt commented Jul 26, 2016

I would try "I'm okay with these commits being contributed to Google", but the CLA bot was overridden manually in this case

@philips
Copy link
Contributor

philips commented Jul 26, 2016

@fabioy Why is explicit approval required for a cherry-pick? The bot should explain the why because I am having a hard time understanding this.

@liggitt
Copy link
Member

liggitt commented Jul 26, 2016

It's the mismatch in committer/author, I think

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 26, 2016

GCE e2e build/test passed for commit beed98b.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit be922c3 into kubernetes:release-1.3 Jul 26, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@philips
Copy link
Contributor

philips commented Jul 26, 2016

@liggitt I understand why the bot triggered but not the logic behind the policy. Why do we care that those two things are different in the case of a cherry-pick? Particularly because it is probably the common case that an owner, not the committer, will cherry-pick things into backport releases.

@liggitt
Copy link
Member

liggitt commented Jul 27, 2016

Yeah, seems like if the author and committer have both signed the CLA, that should be sufficient, especially if the commits are also in master

@philips
Copy link
Contributor

philips commented Jul 27, 2016

@liggitt I am going to try and email github-admin@google.com about this.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…pick-of-#29071-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of kubernetes#29071 upstream release 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.