-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #29071 upstream release 1.3 #29313
Automated cherry pick of #29071 upstream release 1.3 #29313
Conversation
RBAC authorizer assigns a role to a wrong service account.
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@kubernetes/sig-auth any idea how I do this cherry pick properly? |
@derekwaynecarr Any special tags he needs? |
@ericchiang For future reference, please add "cherrypick-candidate" to PR to be considered. |
OK. Here you go. |
GCE e2e build/test passed for commit beed98b. |
CLA check is still unhappy. Is there a specific phrase you have to use to grant consent? |
I would try "I'm okay with these commits being contributed to Google", but the CLA bot was overridden manually in this case |
@fabioy Why is explicit approval required for a cherry-pick? The bot should explain the why because I am having a hard time understanding this. |
It's the mismatch in committer/author, I think |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit beed98b. |
Automatic merge from submit-queue |
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
@liggitt I understand why the bot triggered but not the logic behind the policy. Why do we care that those two things are different in the case of a cherry-pick? Particularly because it is probably the common case that an owner, not the committer, will cherry-pick things into backport releases. |
Yeah, seems like if the author and committer have both signed the CLA, that should be sufficient, especially if the commits are also in master |
@liggitt I am going to try and email github-admin@google.com about this. |
…pick-of-#29071-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#29071 upstream release 1.3
RBAC authorizer assigns a role to a wrong service account.