wow nice

The gcfg change is wrong. See commit a073c80 which says Switch from obsolete "github.com/scalingdata/gcfg" to "gopkg.in/gcfg.v1". Can you figure that out?

Some of the transformations are still imperfect (usually around whitespace) but I think goimports won't fix that.

@jfrazelle This should pass now

GCE e2e build/test passed for commit c88a07c.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Nice. Are we going to have update/verify scripts to keep imports clean?

Thanks,
Dims

we have a gofmt verifier. It could also run goimports.. hint.,..

On Tue, Aug 2, 2016 at 6:16 AM, Davanum Srinivas notifications@github.com
wrote:

Nice. Are we going to have update/verify scripts to keep imports clean?

Thanks,
Dims

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#29230 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVGMOuHr2ydhqHsNIGcW6nBcTe_kTks5qb0M7gaJpZM4JQLtA
.

+1 for adding a script
:)

I also think a script would be nice, but sadly goimports doesn't understand dots in import names, so I had to hand-hack the generated output a bit.

@dims But feel free to open an issue on the goimports side (or maybe fix it), and include it to update/verify-gofmt :)

@jfrazelle Apply the label if this looks good :)

@luxas aha! Can you leave me some notes on what you did and i can try to dig further when i get a chance.

Thanks,
Dims

added LGTM

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit c88a07c.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue